feat(boxai-sidebar): Add is feedback enabled prop to box ai sidebar #3867
Conversation
jankowiakdawid
force-pushed
the
add-is-feedback-enabled-prop-to-box-ai-sidebar
branch
from
8a3082a to
75251df
Compare
|
|
jankowiakdawid
force-pushed
the
add-is-feedback-enabled-prop-to-box-ai-sidebar
branch
from
cb69974 to
f32b658
Compare
package.json
Outdated
| @@ -307,7 +307,7 @@ | |||
| "@box/blueprint-web": "^7.36.3", | |||
| "@box/blueprint-web-assets": "^4.28.0", | |||
There was a problem hiding this comment.
does blueprint-web-assets peer dependency need to be updated?
There was a problem hiding this comment.
yes it should, thank for pointing that up!
| @@ -16,8 +16,10 @@ export interface BoxAISidebarContextValues { | |||
| cache: { encodedSession?: string | null; questions?: QuestionType[] }; | |||
| contentName: string; | |||
| elementId: string; | |||
| isFeedbackEnabled: boolean; | |||
There was a problem hiding this comment.
what happens after the feedback buttons work? in terms making any api calls. i'm not seeing a changes in the apis, does that mean it was already implemented?
There was a problem hiding this comment.
When user clicks feedback buttons the resinAction is being called, no API call are made.
We keep the feedback data in resin tracking.
|
can you update the PR title to follow conventional commit? |
jankowiakdawid
changed the title
This version contains Feedback Thumb Buttons
jankowiakdawid
force-pushed
the
add-is-feedback-enabled-prop-to-box-ai-sidebar
branch
from
4e4eacd to
af2a9c3
Compare
| @@ -70,6 +74,35 @@ const BoxAISidebar = (props: BoxAISidebarProps) => { | |||
| } = props; | |||
| const { questions } = cache; | |||
| const { formatMessage } = useIntl(); | |||
| const contextValue = React.useMemo( | |||
There was a problem hiding this comment.
Are these worth memoizing? Generally useMemo should be used for expensive calculations or deeply nested objects etc.
We're reading
isFeedbackEnabledfrom the host app, and pass it toBoxAiContentAnswers.This is an optional prop that is
falseby default. Whentrueit enables Thumb Feedback Buttons in every answer that record if user consider the answer helpful.