fix(ai-sidebar): Pass additional props to BoxAISidebarContent #3820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkuliczkowski-box
previously approved these changes
Jan 2, 2025
| @@ -80,6 +81,7 @@ const BoxAISidebar = (props: BoxAISidebarProps) => { | |||
| fileID, | |||
| getSuggestedQuestions, | |||
| isIntelligentQueryMode, | |||
| isOpen, | |||
There was a problem hiding this comment.
When looking at the corresponding EUA change, I've come to a conclusion, that I've approved this prematurely :)
Do we need to get this prop from outside? I believe we could pass it to toBoxAISidebarContent always as true, because if the sidebar is closed, BoxAISidebarContent component will never be rendered.
There was a problem hiding this comment.
I agree, let's remove it from props here.
| @@ -116,6 +118,8 @@ const BoxAISidebar = (props: BoxAISidebarProps) => { | |||
| value={{ cache, contentName, elementId, isStopResponseEnabled, setCacheValue, recordAction, userInfo }} | |||
| > | |||
| <BoxAISidebarContent | |||
| getSuggestedQuestions={getSuggestedQuestions} | |||
| isOpen={isOpen} | |||
There was a problem hiding this comment.
Suggested change
| isOpen={isOpen} | |
| isOpen |
karolinaru
force-pushed
the
ai-sidebar-suggested-questions
branch
from
55536cf to
ed885fa
Compare
karolinaru
force-pushed
the
ai-sidebar-suggested-questions
branch
from
ed885fa to
88d0131
Compare
kkuliczkowski-box
approved these changes
Jan 9, 2025
jankowiakdawid
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pass
isOpenandgetSuggestedQuestionstoBoxAISidebarContentallowing suggested questions to load correctly for xlsx files.isOpenindicates whether the AI Sidebar is open or closed.getSuggestedQuestionsIt either returns a function to fetch suggested questions under certain conditions or null when no questions are available.Both props are utilized by
BoxAISidebarContentwhen wrapped inwithApiWrapper, to handle the logic for fetching and displaying suggested questions based on the file type and Sidebar state.Suggested question for xlsx file: