Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(thumbnail-card-details): add keydown callback and default tabindex #3782

Merged
merged 20 commits into from
Jan 6, 2025
Merged

feat(thumbnail-card-details): add keydown callback and default tabindex #3782

merged 20 commits into from
Jan 6, 2025

Conversation

jmcbgaston
Copy link
Contributor

@jmcbgaston jmcbgaston commented Dec 10, 2024 •
edited
Loading

  • ThumbnailCard, ThumbnailCardDetails > Title
    • Add onKeyDown prop for onKeyDown event on Title
    • Add default tabIndex on Title text

@jmcbgaston jmcbgaston self-assigned this Dec 10, 2024
@jmcbgaston jmcbgaston force-pushed the update-thumbnail-card-details-with-callback branch from a06c86a to 1c11a37 Compare December 11, 2024 18:50
@jmcbgaston jmcbgaston force-pushed the update-thumbnail-card-details-with-callback branch from 1c11a37 to 7db5350 Compare December 12, 2024 18:50
@jmcbgaston jmcbgaston marked this pull request as ready for review December 17, 2024 01:02
@jmcbgaston jmcbgaston requested a review from a team as a code owner December 17, 2024 01:02
@jmcbgaston jmcbgaston changed the title feat(thumbnail-card-details): add keydown callback feat(thumbnail-card-details): add keydown callback and default tabindex Dec 17, 2024
@box box deleted a comment from jmcbgaston Dec 17, 2024
@jmcbgaston jmcbgaston requested a review from mickr December 27, 2024 17:09
@jmcbgaston jmcbgaston requested review from greg-in-a-box and removed request for greg-in-a-box December 27, 2024 20:21
@mergify mergify bot merged commit fc09211 into box:master Jan 6, 2025
6 checks passed
@jmcbgaston jmcbgaston deleted the update-thumbnail-card-details-with-callback branch January 6, 2025 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoartaviaq marcoartaviaq marcoartaviaq approved these changes

@mickr mickr mickr approved these changes

@greg-in-a-box greg-in-a-box greg-in-a-box approved these changes

Assignees

@jmcbgaston jmcbgaston

Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmcbgaston @marcoartaviaq @mickr @greg-in-a-box