-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Sanitize proxy credentials #782
feat: Sanitize proxy credentials #782
Conversation
Pull Request Test Coverage Report for Build 3800751862
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Please take a look at the failing integration test
test/unit/util/test_log.py
Outdated
{'http': 'http://username:password@localhost:8080'}, | ||
{'http': 'http://---name:---word@localhost:8080'}, | ||
), | ||
# Test for proxy https | ||
( | ||
{'https': 'http://username:password@localhost:8080'}, | ||
{'https': 'http://---name:---word@localhost:8080'}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure hiding first 4 characters of password is safe enough?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Closes: SDK-2823