Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add redirect_url and declined_redirect_url fields to Sign Request #752

Merged
merged 4 commits into from
Aug 2, 2022

Conversation

congminh1254
Copy link
Member

Closes: SDK-2358

@congminh1254 congminh1254 changed the title feat: Add redirect_url fields to Sign Request feat: Add redirect url fields to Sign Request Jul 26, 2022
@congminh1254 congminh1254 changed the title feat: Add redirect url fields to Sign Request feat: Add additional fields to Sign Request Jul 26, 2022
@coveralls
Copy link

coveralls commented Jul 26, 2022

Pull Request Test Coverage Report for Build 2781213707

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 93.537%

Totals Coverage Status
Change from base Build 2747062647: 0.007%
Covered Lines: 3372
Relevant Lines: 3605

💛 - Coveralls

@congminh1254 congminh1254 force-pushed the sdk-2358-add-redirect_url-fields-box-sign branch from 8bbdb28 to 37fb5d1 Compare July 26, 2022 09:36
Copy link
Contributor

@lukaszsocha2 lukaszsocha2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukaszsocha2 lukaszsocha2 changed the title feat: Add additional fields to Sign Request feat: Add redirect_url and declined_redirect_url fields to Sign Request Aug 2, 2022
@lukaszsocha2 lukaszsocha2 merged commit 5d1f609 into main Aug 2, 2022
@lukaszsocha2 lukaszsocha2 deleted the sdk-2358-add-redirect_url-fields-box-sign branch August 2, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants