Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support file request APIs #747

Merged
merged 5 commits into from
Jul 14, 2022
Merged

feat: Support file request APIs #747

merged 5 commits into from
Jul 14, 2022

Conversation

congminh1254
Copy link
Member

Closes: SDK-1571

@CLAassistant
Copy link

CLAassistant commented Jul 12, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@congminh1254 congminh1254 requested review from lukaszsocha2 and mwwoda and removed request for lukaszsocha2 July 12, 2022 13:09
@coveralls
Copy link

coveralls commented Jul 12, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2664292873

  • 30 of 36 (83.33%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 93.53%
Changes Missing Coverage Covered Lines Changed/Added Lines %
boxsdk/client/client.py 2 3 66.67%
boxsdk/object/file_request.py 28 33 84.85%
Totals Coverage Status
Change from base Build 2624064376: -0.1%
Covered Lines: 3368
Relevant Lines: 3601
💛 - Coveralls

lukaszsocha2
lukaszsocha2 reviewed Jul 13, 2022
View reviewed changes
Copy link
Contributor

@lukaszsocha2 lukaszsocha2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice! Some minor comments to apply

boxsdk/object/file_request.py Outdated Show resolved Hide resolved
boxsdk/object/file_request.py Outdated Show resolved Hide resolved
boxsdk/object/file_request.py Outdated Show resolved Hide resolved
boxsdk/object/file_request.py Outdated Show resolved Hide resolved
test/unit/object/test_file_request.py Outdated Show resolved Hide resolved
boxsdk/object/file_request.py Outdated Show resolved Hide resolved
boxsdk/object/file_request.py Outdated Show resolved Hide resolved
docs/usage/file_request.md Outdated Show resolved Hide resolved
docs/usage/file_request.md Outdated Show resolved Hide resolved
docs/usage/file_request.md Outdated Show resolved Hide resolved
mwwoda
mwwoda approved these changes Jul 14, 2022
View reviewed changes
Copy link
Contributor

@mwwoda mwwoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cool!

@congminh1254 congminh1254 merged commit 71895e3 into main Jul 14, 2022
@congminh1254 congminh1254 deleted the sdk-1571-file-request-api branch July 14, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaszsocha2 lukaszsocha2 lukaszsocha2 left review comments

@mwwoda mwwoda mwwoda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@congminh1254 @CLAassistant @coveralls @lukaszsocha2 @mwwoda