Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for editable shared links for files #737

Merged
merged 2 commits into from
Jun 8, 2022
Merged

feat: Add support for editable shared links for files #737

merged 2 commits into from
Jun 8, 2022
+403 −194

Conversation

lukaszsocha2
Copy link
Contributor

Closes: SDK-2033

@coveralls
Copy link

coveralls commented Jun 6, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2460226151

  • 23 of 23 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 93.602%
Totals Coverage Status
Change from base Build 2460223137: 0.01%
Covered Lines: 3321
Relevant Lines: 3548
💛 - Coveralls

mwwoda
mwwoda approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@mwwoda mwwoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lukaszsocha2 lukaszsocha2 merged commit 1396200 into main Jun 8, 2022
@lukaszsocha2 lukaszsocha2 deleted the sdk-2033-support-editable-shared-links branch June 8, 2022 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwwoda mwwoda mwwoda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukaszsocha2 @coveralls @mwwoda