-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download tar archives from https://github when possible #2263
Conversation
@bower/contributors Please review and test |
Looking at it. |
Even though I couldn't replicate the issue, the code still looks like the solution. |
Sorry, taking time to understand. Not really at ease with bower architecture yet. |
By the way, we need to make sure bower is working for old git versions (e.g. there is no blocking in interactive mode when repository doesn't exist..) |
For me it is pulling from https://github (instead of git://) with this change. |
small point: |
be95ea8
to
39ed77a
Compare
This fixes #2247 as git checkout often fails on older git versions. Additionally .tar.gz archives are downloaded for commits and branches.
FWIW: This change nicely broke all our setups in Travis that had bower get stuff from private repositories. Previously we needed this configuration to make sure SSH authentication is used:
With the change in resolvers we now have to fix all configurations to have redirects for both git:// and https://. |
This fixes #2247 as git checkout often fails on older git versions.
Additionally .tar.gz archives are downloaded for commits and branches.