Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Practice App: Frontend- API homepage #109

Closed
3 tasks done
BElifb opened this issue May 16, 2022 · 5 comments
Closed
3 tasks done

Practice App: Frontend- API homepage #109

BElifb opened this issue May 16, 2022 · 5 comments
Assignees
Labels
Coding The issue is related with coding Effort: Medium Practice App related to the practice app Priority: High This issue must be handled immediately Status: In Progress The issue is being handled.

Comments

@BElifb
Copy link
Contributor

BElifb commented May 16, 2022

What's up?

As discussed in the meetings I will create a template for the homepage.

To Do

  • Create the html template for homepage.
  • Include links for pages that will have input forms for API endpoints.
  • Update urls.py.

Deadline

18.05.2022 @23.59

Additional Information

No response

Reviewers

@KarahanS @kostanya

@BElifb BElifb added Effort: Medium Priority: High This issue must be handled immediately Status: In Progress The issue is being handled. Coding The issue is related with coding Practice App related to the practice app labels May 16, 2022
@BElifb BElifb self-assigned this May 16, 2022
@BElifb
Copy link
Contributor Author

BElifb commented May 16, 2022

  • Created a basic template for homepage (not merged to practice_app yet).
  • Waiting till I implement base template.
  • Question: Do we want separate pages for different methods of the same endpoint? One page per endpoint makes sense but considering some different methods are implemented by different people, might be hard to execute. (I don't mean the urls for API's themselves, for extra user interface functionalities). @KarahanS @kostanya @sinemKocoglu

@BElifb
Copy link
Contributor Author

BElifb commented May 16, 2022

  • All the links redirect to about page till we decide.

@KarahanS
Copy link
Contributor

KarahanS commented May 16, 2022

  • For the question, It seems reasonable to separate pages for different methods of the same endpoint. For example, for different GET requests based on the Art Items, I will be developing different pages. Although it's not the best practice obviously, I believe it makes the work easier. However, one may find implementing all the endpoints in the same page easier as well. Therefore all are allowed to implement their html pages in the way they want.
  • Merged the code in feature/search_by_tag to my local. I believe listing all the url's at the beginning seems ok for now. I'll be adding my routes and push to the feature/artitem.

@BElifb
Copy link
Contributor Author

BElifb commented May 16, 2022

  • Created pull request #114

@KarahanS
Copy link
Contributor

Practice App Implementation is over. No action is taken, closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Coding The issue is related with coding Effort: Medium Practice App related to the practice app Priority: High This issue must be handled immediately Status: In Progress The issue is being handled.
Projects
None yet
Development

No branches or pull requests

2 participants