Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Clicking on a snapshot instantly starts the restore process #3544

Closed
t-nil opened this issue Oct 24, 2024 · 3 comments
Closed

[Bug]: Clicking on a snapshot instantly starts the restore process #3544

t-nil opened this issue Oct 24, 2024 · 3 comments

Comments

@t-nil
Copy link

t-nil commented Oct 24, 2024

Describe the bug

Hi! I just tried to rename a snapshot, but a left-click on it instantly started the restore, which is definitely not what I wanted.
Since this is (correct me) a destructive operation, I think it would be wise to double-check with the user ("are you sure?"); maybe even in the Gnome style of changing the list entry into having ✓and ✗buttons on the right (I think I've seen it someplaces). Of course, a click selecting the snapshot and offering a menu to do things like delete, rename, would also be a wonderful solution!

I'm really not versed enough in Gtk to start a PR myself; would you kindly consider that feature?

image
Also I'm a bit confused as to why one of the entries has a dedicated "Restore" button, but for both entries, simply clicking on them starts the restore.

To Reproduce

  1. Create a bottle
  2. Create multiple snapshots
  3. (Accidentally) click on a snapshot

Package

Flatpak from Flathub

Distribution

Linux ra1n-desktop-manjaro 6.11.5-1-MANJARO #1 SMP PREEMPT_DYNAMIC Wed, 23 Oct 2024 01:37:46 +0000 x86_64 GNU/Linux

Debugging Information

Official Package: true
Version: '51.13'
DE/WM: xfce
Display:
    X.org: true
    X.org (port): :0.0
    Wayland: false
Graphics:
    vendors:
        amd:
            vendor: amd
            envs:
                DRI_PRIME: '1'
            icd: /usr/lib/x86_64-linux-gnu/GL/vulkan/icd.d/radeon_icd.x86_64.json:/usr/lib/i386-linux-gnu/GL/vulkan/icd.d/radeon_icd.i686.json
    prime:
        integrated: null
        discrete: null
Kernel:
    Type: Linux
    Version: 6.11.5-1-MANJARO
Disk:
    Total: 14657966080
    Free: 14657814528
RAM:
    MemTotal: 27.3GiB
    MemAvailable: 13.1GiB
Bottles_envs: null

Troubleshooting Logs

No response

Additional context

I think this is a bug, since a user can accidentally start a destructive non-reversible operation. But if you disagree, feel free to change to "Feature Request"

@mirkobrombin
Copy link
Member

mirkobrombin commented Oct 26, 2024

It’s actually both. Yeah weird

@mirkobrombin mirkobrombin changed the title [Bug]: Clicking on a snapshot instantly starts the restore process (and is not abortable) [Bug]: Clicking on a snapshot instantly starts the restore process Dec 12, 2024
@mirkobrombin
Copy link
Member

Aborting is not possible due to the nature of FVS

@t-nil
Copy link
Author

t-nil commented Jan 5, 2025

Hey, I would argue against closing this issue. The main thing is that Bottles starts this destructive action without asking for additional information. (That should be possible regardless of the process being abortable.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants