Use ca.crt in ssl - rebased #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Lu Ma <lummam@amazon.com> Co-authored-by: John McBride <jpmmcb@amazon.com> Signed-off-by: John McBride <jpmmcb@amazon.com>
gthao313
approved these changes
Sep 28, 2022
Closed
|
Thanks Sean! 👏🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR succeeds and closes #249 (note: it was required to re-create this PR since Lu no longer works on this project)
Issue number:
Closes: #232
Description of changes:
Uses a CA cert in the SSL configuration
Testing done:
Running integration tests now, but should be fine since #249 worked with it's integration tests
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.