-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support HTTP responses without a reason phrase in awsrequest #1932
Conversation
…reason phrase. HTTP responses without a status phrase are valid and should be accepted.
Codecov Report
@@ Coverage Diff @@
## develop #1932 +/- ##
===========================================
- Coverage 92.77% 92.68% -0.09%
===========================================
Files 53 53
Lines 10332 10213 -119
===========================================
- Hits 9585 9466 -119
Misses 747 747
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good to me.
Out of curiosity, how were you running into this? Was this with a proxy server?
@jamesls Sorry, I missed your question here, I discovered this when running against an S3 compatible implementation that ran on Apache Tomcat. is there anything else needed for this to be merged? Thanks! |
Greetings! It looks like this issue hasn’t been active in longer than one year. We encourage you to check if this is still an issue in the latest release. Because it has been longer than one year since the last update on this, and in the absence of more information, we will be closing this issue soon. If you find that this is still a problem, please feel free to provide a comment to prevent automatic closure, or if the issue is already closed, please feel free to reopen it. |
Codecov Report
@@ Coverage Diff @@
## develop #1932 +/- ##
===========================================
+ Coverage 92.79% 93.78% +0.98%
===========================================
Files 53 61 +8
Lines 10332 15115 +4783
===========================================
+ Hits 9588 14176 +4588
- Misses 744 939 +195
Continue to review full report at Codecov.
|
Is there anything missing for this PR to be merged? |
Hi @malaysf, thanks for this PR and your patience on waiting to hear back. After bringing this up for further discussion with the team, we have decided to close this PR. Please let me know if you have any follow-up questions. |
HTTP responses without a status phrase are valid and should be accepted.
#1931