Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support HTTP responses without a reason phrase in awsrequest #1932

Closed

Conversation

malaysf
Copy link

@malaysf malaysf commented Jan 8, 2020

HTTP responses without a status phrase are valid and should be accepted.

#1931

…reason phrase.

HTTP responses without a status phrase are valid and should be accepted.
@codecov-io
Copy link

codecov-io commented Jan 8, 2020

Codecov Report

Merging #1932 into develop will decrease coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1932      +/-   ##
===========================================
- Coverage    92.77%   92.68%   -0.09%     
===========================================
  Files           53       53              
  Lines        10332    10213     -119     
===========================================
- Hits          9585     9466     -119     
  Misses         747      747
Impacted Files Coverage Δ
botocore/awsrequest.py 98.36% <100%> (-0.01%) ⬇️
botocore/model.py 97.82% <0%> (-0.25%) ⬇️
botocore/docs/bcdoc/restdoc.py 96.26% <0%> (-0.17%) ⬇️
botocore/compat.py 94.05% <0%> (-0.07%) ⬇️
botocore/validate.py 98.74% <0%> (-0.07%) ⬇️
botocore/loaders.py 99.24% <0%> (-0.04%) ⬇️
botocore/docs/bcdoc/style.py 95.45% <0%> (-0.04%) ⬇️
botocore/paginate.py 97.8% <0%> (-0.03%) ⬇️
botocore/signers.py 98.08% <0%> (-0.03%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2b0ecb...a3ee541. Read the comment docs.

Copy link
Member

@jamesls jamesls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me.

Out of curiosity, how were you running into this? Was this with a proxy server?

@malaysf
Copy link
Author

malaysf commented Aug 6, 2020

@jamesls Sorry, I missed your question here, I discovered this when running against an S3 compatible implementation that ran on Apache Tomcat.

is there anything else needed for this to be merged? Thanks!

@github-actions
Copy link

github-actions bot commented Aug 6, 2021

Greetings! It looks like this issue hasn’t been active in longer than one year. We encourage you to check if this is still an issue in the latest release. Because it has been longer than one year since the last update on this, and in the absence of more information, we will be closing this issue soon. If you find that this is still a problem, please feel free to provide a comment to prevent automatic closure, or if the issue is already closed, please feel free to reopen it.

@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2021

Codecov Report

Merging #1932 (a3ee541) into develop (210e04c) will increase coverage by 0.98%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1932      +/-   ##
===========================================
+ Coverage    92.79%   93.78%   +0.98%     
===========================================
  Files           53       61       +8     
  Lines        10332    15115    +4783     
===========================================
+ Hits          9588    14176    +4588     
- Misses         744      939     +195     
Impacted Files Coverage Δ
botocore/awsrequest.py 98.63% <100.00%> (+0.26%) ⬆️
botocore/compat.py 89.09% <0.00%> (-5.02%) ⬇️
botocore/docs/shape.py 98.18% <0.00%> (-1.82%) ⬇️
botocore/utils.py 97.60% <0.00%> (-0.86%) ⬇️
botocore/response.py 92.00% <0.00%> (-0.76%) ⬇️
botocore/regions.py 97.97% <0.00%> (-0.74%) ⬇️
botocore/client.py 99.10% <0.00%> (-0.64%) ⬇️
botocore/parsers.py 99.72% <0.00%> (-0.08%) ⬇️
botocore/args.py 100.00% <0.00%> (ø)
botocore/config.py 100.00% <0.00%> (ø)
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 210e04c...a3ee541. Read the comment docs.

@ThierryGoeckel
Copy link

Is there anything missing for this PR to be merged?

@RyanFitzSimmonsAK
Copy link
Contributor

Hi @malaysf, thanks for this PR and your patience on waiting to hear back. After bringing this up for further discussion with the team, we have decided to close this PR. Please let me know if you have any follow-up questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants