Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

botocore still ignore "HTTP/1.1 100" #3149

Closed
kbgksj opened this issue Mar 29, 2024 · 2 comments
Closed

botocore still ignore "HTTP/1.1 100" #3149

kbgksj opened this issue Mar 29, 2024 · 2 comments
Assignees
Labels
bug This issue is a confirmed bug. duplicate This issue is a duplicate.

Comments

@kbgksj
Copy link

kbgksj commented Mar 29, 2024

Describe the bug

Related Issue

I think botocore still ignore "HTTP/1.1 100" that does not contain reason-phrase content (Continue).
Is there any reason?

Expected Behavior

When a s3 server returns 100 Status code without reason phrase (Continue),
boto3 should work without errors.

Current Behavior

boto3 raises errors ( botocore.exceptions.ConnectionClosedError: Connection was closed before we received a valid response from endpoint URL )

Reproduction Steps

  1. Run boto3's put_object function to a custom endpoint_url (custom s3 server)
  2. If a custom s3 server returns 100 code without reason phrase, the client (boto3) raises errors

Possible Solution

change one of the following functions in awsrequest.py (https://github.com/boto/botocore/blob/develop/botocore/awsrequest.py)

  • _is_100_continue_status
  • _handle_expect_response

Additional Information/Context

No response

SDK version used

Version: 1.34.73

Environment details (OS name and version, etc.)

Redhat 7.9

@kbgksj kbgksj added bug This issue is a confirmed bug. needs-triage This issue or PR still needs to be triaged. labels Mar 29, 2024
@tim-finnigan tim-finnigan self-assigned this May 8, 2024
@tim-finnigan
Copy link
Contributor

tim-finnigan commented May 8, 2024

Thanks for bringing this issue back to our attention. It looks like the original issue (#1931) auto-closed due to lack of activity. I can reopen that one to continue tracking and bring it up with the team for discussion. It looks like a PR was submitted for this (#1932) and was approved but the team decided to close it and its not clear why. Please refer to that original issue for updates going forward.

@tim-finnigan tim-finnigan closed this as not planned Won't fix, can't repro, duplicate, stale May 8, 2024
@tim-finnigan tim-finnigan added duplicate This issue is a duplicate. and removed needs-triage This issue or PR still needs to be triaged. labels May 8, 2024
Copy link

github-actions bot commented May 8, 2024

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a confirmed bug. duplicate This issue is a duplicate.
Projects
None yet
Development

No branches or pull requests

2 participants