-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
S3 multi-part part number type documentation #3501
Comments
Thanks @mdavis-xyz for reporting this issue. |
@tim-finnigan I would like to fix this issue, So we have to fix the document or code? |
I think we can just change the documentation. An int is more intuitive than a string. |
Wanted to raise this again - we use autogenerated type hints (https://github.com/vemel/mypy_boto3_builder) which make it very easy to introduce this runtime bug. I'm be happy to help fix this although I have to admit I don't know where the particular change would be (I assume the docs are autogenerated somehow...). |
The issue was addressed in the latest If the issue is related to auto-generated type annotations for |
Thank you! I can confirm that release 1.35.1 of boto3-stubs fixes the issue for me. |
Describe the issue
The documentation for S3 multipart upload
Part
says:If I use a string (
Part('1')
) I get an error. If I use an intPart(1)
I don't get an error. So the library behavior does not match the documentation.Steps to reproduce
MWE
Run this script.
Expected behavior
Script completes successfully using
Part('1')
. Multipart upload completed.Actual behavior
If I change
Part('1')
toPart(1)
the exception is no longer thrown.Links
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/s3.html#S3.MultipartUpload.Part
The text was updated successfully, but these errors were encountered: