From ceda63bd5977aa2fb61c446af0232c89e9bc4b43 Mon Sep 17 00:00:00 2001
From: Mark Sharp <mark.sharp@solent.ac.uk>
Date: Mon, 27 Jan 2025 11:57:53 +0000
Subject: [PATCH] CONTRIB-9675: Fix dynamic vars and mistyped var

---
 bookingform.php | 2 ++
 renderable.php  | 4 ++--
 teacherview.php | 1 -
 3 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/bookingform.php b/bookingform.php
index 4ae84b0e..5491f490 100644
--- a/bookingform.php
+++ b/bookingform.php
@@ -46,6 +46,8 @@ class scheduler_booking_form extends moodleform {
     protected $uploadoptions;
     /** @var mixed */
     protected $existing;
+    /** @var bool */
+    protected $noteoptions = [];
 
     /**
      * scheduler_booking_form constructor.
diff --git a/renderable.php b/renderable.php
index 38c3bb7f..b6654a01 100644
--- a/renderable.php
+++ b/renderable.php
@@ -688,7 +688,7 @@ public static function make_from_appointment(slot $slot, appointment $appointmen
         $info->appointment = $appointment;
         $info->scheduler = $slot->get_scheduler();
         $info->showslotinfo = true;
-        $info->showboookinginfo = true;
+        $info->showbookinginfo = true;
         $info->showstudentdata = $info->scheduler->uses_studentdata();
         $info->showresult   = true;
         $info->onstudentside = $onstudentside;
@@ -711,7 +711,7 @@ public static function make_for_teacher(slot $slot, appointment $appointment) {
         $info->appointment = $appointment;
         $info->scheduler = $slot->get_scheduler();
         $info->showslotinfo = true;
-        $info->showboookinginfo = false;
+        $info->showbookinginfo = false;
         $info->showstudentdata = $info->scheduler->uses_studentdata();
         $info->showresult   = false;
         $info->onstudentside = false;
diff --git a/teacherview.php b/teacherview.php
index a5dc7094..a3b9cff3 100644
--- a/teacherview.php
+++ b/teacherview.php
@@ -471,7 +471,6 @@ function scheduler_print_schedulebox(scheduler $scheduler, $studentid, $groupid
     $PAGE->requires->js_call_amd('mod_scheduler/delselected', 'init', [$delselectedurl->out(false)]);
     $delselected = $commandbar->action_menu_link($delselectedurl, 'deleteselection', 't/delete',
                                                 'confirmdelete-selected', 'delselected');
-    $delselected->formid = 'delselected';
     $delbuttons[] = $delselected;
 
     if ($permissions->can_edit_all_slots() && $subpage == 'allappointments') {