Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement StyleCI #92

Open
tejasmanohar opened this issue Feb 28, 2015 · 13 comments
Open

implement StyleCI #92

tejasmanohar opened this issue Feb 28, 2015 · 13 comments
Assignees
Labels

Comments

@tejasmanohar
Copy link
Contributor

https://styleci.io/

@d11wtq, what do you think about implementing StyleCI? I would myself, but it only allows you to do this on repos you own, not collaborate to.

@GrahamCampbell
Copy link

not collaborate to.

It allows all repos you're "admin" on, rather than ones you physically own.

@tejasmanohar
Copy link
Contributor Author

@GrahamCampbell Ah, alright. Can't have multiple admins on personal repos, I believe.

@GrahamCampbell
Copy link

Can't have multiple admins on personal repos, I believe.

Nope, you deffo can. I know repos that have like 12 admins on them.

@GrahamCampbell
Copy link

GitHub let's admins choose "read", "write", "admin" when you're added as a collaborator.

@tejasmanohar
Copy link
Contributor Author

@GrahamCampbell I can't find that option in any of my repos. Would you post a screenshot / tutorial to demonstrate?

+github docs

You can grant read/write access to collaborators on a personal repository. Repositories owned by an organization can grant more granular access. For more information, see "What are the different access permissions?"

-- from Adding collaborators to a personal repository

  • looks like this on my repo (can't change access part)

imgur

@tejasmanohar
Copy link
Contributor Author

anyways, putting us back on topic. @GrahamCampbell feel free to email me if you find out, email is on github profile

https://styleci.io/
@d11wtq, what do you think about implementing StyleCI? I would myself, but it only allows you to do this on repos you own, not collaborate to.

@GrahamCampbell
Copy link

To be honest, if boris has multiple maintainers, it would make sense to move it to an organisation. We did that a few weeks ago with class preloader. https://github.com/ClassPreloader/ClassPreloader

@GrahamCampbell
Copy link

@tejasmanohar
Copy link
Contributor Author

@GrahamCampbell - Makes sense.

Chaining @d11wtq in on this 👍

@d11wtq
Copy link
Contributor

d11wtq commented Mar 5, 2015

I've converted this repository to an organization and you have admin access now. No objections to StyleCI, nope. I'm easy on coding style, just as long as it's consistent, although I do have a dislike for tabs mostly because they render terribly/unpredictably in things like cat/less/the browser.

@GrahamCampbell
Copy link

although I do have a dislike for tabs

StyleCI only supports fixing to spaces atm anyway. :)

@GrahamCampbell
Copy link

Why would you want tabs? lol

@tejasmanohar
Copy link
Contributor Author

@GrahamCampbell I mean tabs do have their advantages, like being able to set the appearance custom in your environment, but @d11wtq brings up a good point so we will continue to use spaces.

I'll implement this before EOD tmrw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants