-
-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace IList<> with IEnumerable<> #147
Comments
Implemented with 2.4.2 |
Reverted to IList with 2.4.3 because of UpdateEntitiesIdentity(SetOutputIdentity). EFCore.BulkExtensions/EFCore.BulkExtensions/TableInfo.cs Lines 458 to 462 in c0b9aa5
|
Having IList for bulk operations doesn't make much sense to me. If I need to insert millions of rows, am I supposed to load them all in memory? I guess I can still split rows in reasonable chunks and call bulkInserts multiple times but it's kinda weird that I have to do that. |
Can't you just assign
and keep using IEnumerable instead of IList? In my scenario I'm reading sequentially from a .csv file and I really want to avoid using up too much memory by loading up all the rows into memory... |
It needs to update the callers view of the elements rather than just the local reference? |
Closing this issue still doesn't solve the problem when the data is read sequentially from a file for example. IList loads everything into memory... so for bulk operations, as others have mentioned it's not very helpful. |
Bulk methods are now receiving IEnumerable. |
I did not see any specific IList<> functionality (at least for the bulk insert). It would be helpful to change this the bulk input parameters to IEnumerable<> to prevent having to wrap collections into List objects to use the methods.
The text was updated successfully, but these errors were encountered: