Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple backups at a time #655

Closed
samuel-w opened this issue Sep 18, 2020 · 3 comments
Closed

Allow multiple backups at a time #655

samuel-w opened this issue Sep 18, 2020 · 3 comments
Labels
priority:low Nice to have feature, minor improvement to functionality or usability status:planning For large features, plan it out before implementation type:enhancement Improvement of an existing function

Comments

@samuel-w
Copy link
Contributor

Describe the bug
I cannot run multiple backups at a time, even though they are in different repositories.

To Reproduce
Steps to reproduce the behavior:

  1. Start a backup in one profile
  2. Go to another profile with a different repository, and try to start a backup
    Result: Backup button is greyed out, even though you can run multiple backups at a time from the command line

Desktop (please complete the following information):

  • OS: Ubuntu 20.04
  • Vorta version: 0.7.1
  • Borg version: 1.1.11

Vorta and Borg versions can be found in Main Window > Misc Tab

Additional context
Must fix for #103

@m3nu
Copy link
Contributor

m3nu commented Sep 18, 2020

That's correct. There can only be one Borg process at a time. The logging and other things are all set up on this assumption. To change it:

  • The Borg lock needs to work at the profile level, not globally. (The same repo can be used in multipe profiles so this case needs handling too)
  • How to deal with logs and status updates, when multiple processes are running?
  • ...

We can keep this issue open, but it's a bigger project for sure.

@m3nu m3nu added priority:low Nice to have feature, minor improvement to functionality or usability status:planning For large features, plan it out before implementation type:enhancement Improvement of an existing function labels Sep 18, 2020
@samuel-w
Copy link
Contributor Author

For checking borg lock we can check if lock.exclusive exists in the repo url. Not sure about remote.

Status updates we could separate by profile when multiple are running, so that you could only see the current profile's status.
Logs are thread safe already, https://docs.python.org/3/library/logging.html#thread-safety. We could append the repo url for clarity.

@samuel-w
Copy link
Contributor Author

As an alternative, we could implement multiple backups as a queue. It would be easier, just run the next in queue after the current ends.

@m3nu m3nu closed this as completed Feb 15, 2021
@borgbase borgbase locked and limited conversation to collaborators Feb 15, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
priority:low Nice to have feature, minor improvement to functionality or usability status:planning For large features, plan it out before implementation type:enhancement Improvement of an existing function
Projects
None yet
Development

No branches or pull requests

2 participants