Diff doesn't always work

[harmlessdrudge]

Describe the bug

Diff function works sometimes, but often does nothing.

To Reproduce

Click on Archives, then DIff, select last two backups and then click diff

Result is nothing shown here, despite hundreds of Mb of additional files.

Desktop (please complete the following information):

Linux Mint 19.3 w Cinnamon desktop

Additional context
If appropriate include logs. Can be found in Main Window > Misc Tab > Log.
vorta.log

[samuel-w]

I've had this happen too, even after just opening, but it goes away with a restart of Vorta. It might be related to #553, since I haven't experienced it since it was merged.

[ktosiek]

Do you see an entry for borg-run diff in Schedule -> Log? If so, what's the Returncode?

[harmlessdrudge]

Yes, Returncode seems to be 0 regardless of whether or not any differences are displayed (every diff Returncode is 0).

[ThomasWaldmann]

@harmlessdrudge can you reproduce an issue when just using borg directly? if so, please file a bug on the borg issue tracker.

[harmlessdrudge]

Maybe this will help

`
2020-09-04 17:27:23,639 - vorta.i18n - DEBUG - Loading translation failed for ['en-IE', 'en-Latn-IE'].
2020-09-04 17:27:23,663 - apscheduler.scheduler - INFO - Scheduler started
2020-09-04 17:27:23,665 - apscheduler.scheduler - INFO - Added job "VortaScheduler.create_backup" to job store "default"
2020-09-04 17:27:23,665 - vorta.scheduler - DEBUG - New job for profile Default was added.
2020-09-04 17:27:23,715 - vorta.borg.borg_thread - INFO - Running command /usr/bin/borg --version
2020-09-04 17:28:06,454 - vorta.borg.borg_thread - DEBUG - Using VortaSecretStorageKeyring keyring to store passwords.
2020-09-04 17:28:06,455 - asyncio - DEBUG - Using selector: EpollSelector
2020-09-04 17:28:06,460 - root - DEBUG - Found 1 passwords matching repo URL.
2020-09-04 17:28:06,521 - vorta.borg.borg_thread - INFO - Running command /usr/bin/borg diff --info --log-json /mnt/linuxbackup/T440Mint/borg::T440-default-2020-09-02T13:00:00 T440-default-2020-09-03T13:00:00
Traceback (most recent call last):
File "/usr/local/lib/python3.6/dist-packages/vorta/views/archive_tab.py", line 460, in list_diff_result
window = DiffResult(result['data'], archive_newer, archive_older)
File "/usr/local/lib/python3.6/dist-packages/vorta/views/diff_result.py", line 72, in init
files_with_attributes.append(parse_line(line))
File "/usr/local/lib/python3.6/dist-packages/vorta/views/diff_result.py", line 60, in parse_line
full_path = line[full_path_index:]
UnboundLocalError: local variable 'full_path_index' referenced before assignment

`

[samuel-w]

It is indeed related to #553. Try running Vorta from master.
Note: You will not be able to return back to running the released version of Vorta until it updates. Backup your profile (usually in ~.local/share/Vorta/) and restore it later.

[samuel-w]

Actually, it is the exact same line with the exact same trace as #553's issue. This is fixed by #553. Closed.

Note: We should push an update to fix this bug, since someone else #589 has this problem.