You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We already use pre-commit hooks for QA. However when a contributor doesn't install pre-commit, he can introduce unchecked and unformatted changes that will be require further action for contributors using pre-commit down the line. Currently there is no Github Action enforcing the pre-commit hooks for pull requests. There I would like to add a ci check that runs pre-commit.
Possible Solutions
There are multiple options here:
Add pre-commit command to the lint phony in the Makefile
Use the pre-commit.cibot that can automatically add a commit with the autofixes from the pre-commit hooks and can run pre-commit autoupdate regularly.
Use the pre-commit.ci lite action that can autofix PRs too.
M3nu has already said that he dislikes bot commits: #1394 (comment)
So option 1 is probably the best. However one could also implement a custom action that commits pre-commit fixes under the name of the previous committer. This should be quite straight-forward iirc.
The text was updated successfully, but these errors were encountered:
The problem
We already use pre-commit hooks for QA. However when a contributor doesn't install pre-commit, he can introduce unchecked and unformatted changes that will be require further action for contributors using pre-commit down the line. Currently there is no Github Action enforcing the pre-commit hooks for pull requests. There I would like to add a ci check that runs pre-commit.
Possible Solutions
There are multiple options here:
pre-commit
command to thelint
phony in the Makefilepre-commit autoupdate
regularly.M3nu has already said that he dislikes bot commits: #1394 (comment)
So option 1 is probably the best. However one could also implement a custom action that commits pre-commit fixes under the name of the previous committer. This should be quite straight-forward iirc.
The text was updated successfully, but these errors were encountered: