Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: the Size column in the archives list is hard to read due to the mixed units. My proposed change (pull request incoming, need help if possible) #1595

Closed
hariseldon78 opened this issue Feb 17, 2023 · 3 comments · Fixed by #1598
Labels
type:enhancement Improvement of an existing function

Comments

@hariseldon78
Copy link
Contributor

I find hard to read the sizes of the archives at a glance when they are all mixed units: usually the longer numbers represent smaller sizes, making it difficult to find the biggest archives. So I made a basic algorithm to select a good unit that can adequately represent all sizes, that makes it much easier to read. Also I made the column align to the right, which further improves readability.

This is a screenshot of my proposed change
image

@hariseldon78 hariseldon78 added the type:enhancement Improvement of an existing function label Feb 17, 2023
@hariseldon78
Copy link
Contributor Author

hariseldon78 commented Feb 17, 2023

sorry, the pull request is not ready yet, the tests are failing and I can't pinpoint the cause.. if somebody can help me here's my fork: https://github.com/hariseldon78/vorta
Basically the tests crashes in some way when they executes the utils/find_best_size_formatting function, even though it works perfectly when running the application. If I don't call that function they pass.

@hariseldon78 hariseldon78 changed the title FR: the Size column in the archives list is hard to read due to the mixed units. My proposed change (with pull request) FR: the Size column in the archives list is hard to read due to the mixed units. My proposed change (pull request incoming, need help if possible) Feb 17, 2023
@real-yfprojects
Copy link
Collaborator

Just open a pull request, possibly as a draft. I can have a look then.

@hariseldon78
Copy link
Contributor Author

Just open a pull request, possibly as a draft. I can have a look then.

ok, here it is: #1598

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement Improvement of an existing function
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants