Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Malformed .vorta-init.json causes Vorta to crash on startup without error #1053

Closed
phihos opened this issue Aug 11, 2021 · 1 comment
Closed

Comments

@phihos
Copy link
Contributor

phihos commented Aug 11, 2021

Hi,

in my company we started to adopt Vorta with the bootstrapping feature I implemented some time ago.
I made a mistake when implementing the bootstrapping by not handling malformed JSON very well.

Steps to reproduce:

  1. Close Vorta if opened.
  2. Plase a file containing garbled JSON like } in ~/.vorta-init.json
  3. Start Vorta.

What should happen is that the user is at least notified of the failed import attempt. Also the program should still be usable by simply skipping the profile import on error.
What actually happens is nothing visible. There is a stacktrace logged to console, but this does not help the average user. And then Vorta terminates.

I have already something ready and will make a PR shortly.

@m3nu
Copy link
Contributor

m3nu commented Aug 12, 2021

Thanks for fixing! We always learn more, once the rubber hits the road. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants