Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

borg2 commands: use repo-*, not r* #8292

Closed
ThomasWaldmann opened this issue Jul 19, 2024 · 7 comments · Fixed by #8358
Closed

borg2 commands: use repo-*, not r* #8292

ThomasWaldmann opened this issue Jul 19, 2024 · 7 comments · Fixed by #8358
Assignees
Milestone

Comments

@ThomasWaldmann
Copy link
Member

#7647 as discussed / voted there (voting is / will be open until this ticket is close, so in case you missed it, you can still vote there).

Current state of repo-level commands:

borg rcreate
borg rlist
borg rinfo
borg rdelete
...

Change to:

borg repocreate
borg repolist
borg repoinfo
borg repodelete
...
@ThomasWaldmann ThomasWaldmann added this to the 2.0.0rc1 milestone Jul 19, 2024
@ThomasWaldmann
Copy link
Member Author

ThomasWaldmann commented Jul 31, 2024

Maybe repo-create etc. would be even better style / better readable.

@ThomasWaldmann ThomasWaldmann modified the milestones: 2.0.0rc1, 2.0.0b10 Aug 31, 2024
@ThomasWaldmann
Copy link
Member Author

ThomasWaldmann commented Aug 31, 2024

@m3nu @sophie-h @witten See above, guess b10 would be a good time for that change.

As we only want to change that once and then keep it for borg2 for a long time, just wanted to ask if we are all fine with repo-* instead of the r* commands or would you prefer repo* without the dash?

Options (was: rcreate):

  • repo-create
  • repocreate

@m3nu
Copy link
Contributor

m3nu commented Aug 31, 2024

repoxxx looks good to me.

@witten
Copy link
Contributor

witten commented Aug 31, 2024

Either repo* or repo-* will be the same amount of work (a fair amount, actually!) from borgmatic's perspective. Looking at it as a user though, I might have a slight preference for repo*. (Easier to type.)

@RonnyPfannschmidt
Copy link
Contributor

I strongly recommend dashes as readability is so much better with a little visual clue

@ThomasWaldmann
Copy link
Member Author

ThomasWaldmann commented Sep 1, 2024

@RonnyPfannschmidt same here (and also that editors like pycharm see words like repocreate as mis-spelled and underline them in red - nothing major, but slightly ugly. pycharm is fine with repo-create).

@ThomasWaldmann
Copy link
Member Author

OK, we'll go with repo-*.

It's a bit more to type (but repo-level commands are a bit less frequent than archive level), but reads better.

@ThomasWaldmann ThomasWaldmann changed the title borg2 commands: use repo*, not r* borg2 commands: use repo-*, not r* Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants