Release 2.0.0b8, beta quality, for testing only

[ThomasWaldmann]

borgbackup 2.0.0b8 beta release - do not use this on production backup repositories.

Long changelog:
https://borgbackup.readthedocs.io/en/2.0.0b8/changes.html#version-2-0-0b8-2024-02-20

If you use pip to install this, use: pip install "borgbackup==2.0.0b8"

Docs: https://borgbackup.readthedocs.io/en/2.0.0b8/

Feedback: XXX

---

This discussion was created from the release Release 2.0.0b8, beta quality, for testing only.

[BapRx]

Hi, I have a regression after upgrading from 2.0.0b7 to 2.0.0b8, my backup job always fails with the following error:

IntegrityError: Authentication / EVP_DecryptFinal_ex failed

I'm using Borg with borgmatic but only updated borg. I just tried listing my repository and it also fails. Downgrading to 2.0.0b7 fixes the issue.

2.0.0b7 test

borgmatic-866c87f7c5-8t545:/# env | grep BORG_
BORG_EXIT_CODES=modern
BORG_PASSPHRASE=<redacted>
BORG_HOST_ID=backups
borgmatic-866c87f7c5-8t545:/# borg rlist -r /srv/backups/my-repo.borg
borgmatic-58795f6bbd-p8p84-2023-06-12T01:00:40.309729 Mon, 2023-06-12 01:00:40 +0000 [3ec035210ba3648d0ce0daaa6d2da420a1e6d9e1e114e4807f18fff284c0e6fc]
[...]
borgmatic-7f85d87f8c-lr8rx-2024-02-21T01:00:19.155514 Wed, 2024-02-21 01:00:19 +0000 [ce1526cdd94666bfb89b6b4ac1c4273b870376a424c98abb51901b95ab84921a]
borgmatic-866c87f7c5-8t545:/# borg --version
borg 2.0.0b7

2.0.0b8 test

borgmatic-5f65cf6c5d-flcqc:/# env | grep BORG_
BORG_EXIT_CODES=modern
BORG_PASSPHRASE=<redacted>
BORG_HOST_ID=backups
borgmatic-5f65cf6c5d-flcqc:/# borg rlist -r /srv/backups/my-repo.borg
Local Exception

Error:

IntegrityError: Authentication / EVP_DecryptFinal_ex failed

If reporting bugs, please include the following:

Traceback (most recent call last):
  File "/usr/local/lib/python3.12/site-packages/borg/archiver/__init__.py", line 656, in main
    exit_code = archiver.run(args)
                ^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/borg/archiver/__init__.py", line 549, in run
    rc = func(args)
         ^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/borg/archiver/_common.py", line 141, in wrapper
    manifest_ = Manifest.load(repository, compatibility)
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/borg/manifest.py", line 258, in load
    _, data = manifest.repo_objs.parse(cls.MANIFEST_ID, cdata, ro_type=ROBJ_MANIFEST)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/borg/repoobj.py", line 109, in parse
    meta_packed = self.key.decrypt(id, meta_encrypted)
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/borg/crypto/key.py", line 859, in decrypt
    return cipher.decrypt(data, aad=id)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "src/borg/crypto/low_level.pyx", line 553, in borg.crypto.low_level._AEAD_BASE.decrypt
borg.crypto.low_level.IntegrityError: Authentication / EVP_DecryptFinal_ex failed

Platform: Linux borgmatic-5f65cf6c5d-flcqc 6.4.3-060403-generic #202307110536 SMP PREEMPT_DYNAMIC Tue Jul 11 05:43:58 UTC 2023 x86_64
Linux: Unknown Linux
Borg: 2.0.0b8  Python: CPython 3.12.2 msgpack: 1.0.7 fuse: llfuse 1.5.0 [pyfuse3,llfuse]
PID: 514  CWD: /
sys.argv: ['/usr/local/bin/borg', 'rlist', '-r', '/srv/backups/my-repo.borg']
SSH_ORIGINAL_COMMAND: None


borgmatic-5f65cf6c5d-flcqc:/# borg version
2.0.0b8 / 2.0.0b8

let me know if I should open an issue instead of commenting here 🙂

[BapRx]

Alright, I was't sure if this behavior was a bug or a known breaking change. I'll move on with a new repo then, thanks for providing a quick answer!

[awgcooper]

I received the same error trying to backup an existing repo using the latest version:

IntegrityError: Authentication / EVP_DecryptFinal_ex failed

I don't have time right now to do anything else but wanted to convey the message. I will try and create a new repo / transfer existing if I get less busy in the new few days.

[ThomasWaldmann]

When testing betas, there should be no expectation for compatibility or upgrade procedures.

If the old repo doesn't work, just create a new one. If I do bigger changes, breakage of compatibility to old beta repos is expected.

[rovo89]

When testing betas, there should be no expectation for compatibility or upgrade procedures.

Looking at https://github.com/borgbackup/borg/milestone/90, we're still quite far from a release candidate, right?

I can totally understand you though, as a maintainer I wouldn't want to limit myself at an early stage. That's why you created a new version.

More for the theory: If one server runs b7 and another one runs b8, could a transfer between the two work? Both servers could read/write their respective file formats. If the data sent by transfer is more version-agnostic (because I could imagine that the wire protocol is different and just transfers the raw data), than this could be a workaround to migrate repositories.

[ThomasWaldmann]

Yes, rc will take quite a while still. That doesn't mean that all issues in that milestones must be solved, for some it is rather "if someone has time, these can be looked at".

borg transfer working for b7 -> b8: I guess likely it won't work. It can only work if borg has code for both repo formats and that is only maintained for borg 1.2 and the current format.

[dsvf]

Running borg benchmark cpu causes a crash.
Using version 2.0.0.b8 borg-linux-glibc231 on a Debian 11 VPS

[...] previous benchmarks pass ok
msgpack ========================================================
msgpack      100k Items 0.264s
Local Exception

Error:

AssertionError:

If reporting bugs, please include the following:

Traceback (most recent call last):
  File "borg/archiver/__init__.py", line 656, in main
  File "borg/archiver/__init__.py", line 550, in run
AssertionError

Platform: Linux ferhana.de 5.10.0-23-amd64 #1 SMP Debian 5.10.179-1 (2023-05-12) x86_64
Linux: Unknown Linux
Borg: 2.0.0b8  Python: CPython 3.11.7 msgpack: 1.0.7 fuse: llfuse 1.5.0 [pyfuse3,llfuse]
PID: 3585635  CWD: /home/phil
sys.argv: ['borg', 'benchmark', 'cpu']
SSH_ORIGINAL_COMMAND: None```

[dsvf]

Also, running borg key export without a target filename throws an exception instead of handling it gracefully

Here's the full error, for completeness' sake:

Local Exception

Error:

TypeError: stat: path should be string, bytes, os.PathLike or integer, not NoneType

If reporting bugs, please include the following:

Traceback (most recent call last):
  File "borg/archiver/__init__.py", line 656, in main
  File "borg/archiver/__init__.py", line 549, in run
  File "borg/archiver/_common.py", line 158, in wrapper
  File "borg/archiver/key_cmds.py", line 100, in do_key_export
  File "<frozen genericpath>", line 42, in isdir
TypeError: stat: path should be string, bytes, os.PathLike or integer, not NoneType

Platform: Linux ferhana.de 5.10.0-23-amd64 #1 SMP Debian 5.10.179-1 (2023-05-12) x86_64
Linux: Unknown Linux
Borg: 2.0.0b8  Python: CPython 3.11.7 msgpack: 1.0.7 fuse: llfuse 1.5.0 [pyfuse3,llfuse]
PID: 3586713  CWD: /root
sys.argv: ['borg', 'key', 'export']
SSH_ORIGINAL_COMMAND: None```

[ThomasWaldmann]

Fixed by #8291.