Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Small modals instead of large modals #42

Closed
Waxolunist opened this issue Sep 29, 2014 · 4 comments
Closed

[CLOSED] Small modals instead of large modals #42

Waxolunist opened this issue Sep 29, 2014 · 4 comments
Milestone

Comments

@Waxolunist
Copy link
Contributor

Issue by KeyKaKiTO
Monday Mar 10, 2014 at 14:35 GMT
Originally opened as Waxolunist/bootstrap3-wysihtml5-bower#42


First of all, thanks for forking an old repository and keeping it up.

Insert image and insert link modals are very large (for that amount of content).

Bootstrap has a class for small modal (.modal-sm applied to .modal-dialog).

It's far more pretty than the large one.

But again thanks for your great work :)

@Waxolunist Waxolunist added this to the 0.2.10 milestone Sep 29, 2014
@Waxolunist
Copy link
Contributor Author

Comment by KeyKaKiTO
Monday Mar 10, 2014 at 15:25 GMT


Oh I saw there is a blockqoute element in your fork, awesome, but it has default styles.

I don't know if there is a way to add styles (without adding more stylesheets) to that iframe, it would be really awesome! (I tried once and end up with overriding wysihtml5 itself! with just a bit of changes in source!)

@Waxolunist
Copy link
Contributor Author

Comment by Waxolunist
Tuesday Mar 11, 2014 at 06:55 GMT


The class modal-sm limits only the width of the modal, right? So when having long links, you can't see the whole string. However, I will make it an option.

To your second question. Please open a second issue.
If you are applying the wysithml5 method to a div in 0.3.0 you probably don't have to add a stylesheet. But without stylesheet, I don't see a chance. I will have a look into it.
If you made changes to the source and want to share, please open a PR.

Btw, thx for the kudos.

@Waxolunist
Copy link
Contributor Author

Comment by KeyKaKiTO
Tuesday Mar 11, 2014 at 07:32 GMT


If I get spare time I will add fa-IR translation, and will check your repo (since it has changed from the original one) and will add parts from my edited version.

@Waxolunist
Copy link
Contributor Author

Comment by Waxolunist
Tuesday Mar 11, 2014 at 07:41 GMT


I added the option to v0.3.0-alpha.5 and v0.2.10-alpha.1. Please try.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant