Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow special characters in Team Name #275

Closed
tlawrie opened this issue Oct 24, 2021 · 4 comments · Fixed by boomerang-io/flow.client.web#134
Closed

Allow special characters in Team Name #275

tlawrie opened this issue Oct 24, 2021 · 4 comments · Fixed by boomerang-io/flow.client.web#134
Assignees
@timrbula
Labels
task

Comments

@tlawrie
Copy link
Member

tlawrie commented Oct 24, 2021 •
edited
Loading

Change

  • Update Team Name to allow a list of special characters such as ' however probably no need to support all special characters.
@tlawrie tlawrie added the task label Oct 24, 2021
@tlawrie tlawrie self-assigned this Oct 24, 2021
@tlawrie tlawrie changed the title Team Name doesnt allow special characters such as Team Name doesnt allow special characters Oct 24, 2021
@tlawrie
Copy link
Member Author

tlawrie commented Jan 12, 2022

In looking at the code. I don't see any validation restricting this on the service side. @marcusdroy can you confirm?

@tlawrie
Copy link
Member Author

tlawrie commented Feb 1, 2022

Good question from @timrbula around what characters do we want to allow?

Any unicode character. Yay to emoji's 🐼

@tlawrie
Copy link
Member Author

tlawrie commented Feb 1, 2022

Add support to render emoji

@tlawrie tlawrie changed the title Team Name doesnt allow special characters Allow special characters in Team Name Feb 15, 2022
@timrbula
Copy link
Member

timrbula commented Mar 29, 2022 •
edited
Loading

@timrbula to delete a line of code to support this and communicate with CICD team about supporting all Unicode characters now.

@timrbula timrbula mentioned this issue Apr 12, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timrbula timrbula

Labels
task
Projects
Boomerang Flow
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support unicode team name and add length constraint boomerang-io/flow.client.web
5 participants
@timrbula @tlawrie @Okisa @LucasGrimauth @BenjaminRuby