Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle result parameters for Tasks with unknown or dynamic results #135

Closed
tlawrie opened this issue May 21, 2021 · 3 comments
Closed

Handle result parameters for Tasks with unknown or dynamic results #135

tlawrie opened this issue May 21, 2021 · 3 comments
Assignees
Labels
project: flow Tasks for Boomerang Flow task

Comments

@tlawrie
Copy link
Member

tlawrie commented May 21, 2021

With the move to Tekton Task Results needing to be defined rather than be dynamic we need to understand how to do this for the tasks that don't have predefined result parameters such as:

  • script
  • custom tasks
  • JSON to result parameter

Possible solutions are;

  1. Add a result parameter creatable to the Script and Custom task types
  2. Figure out how to include the dynamic result parameter creation as a side car (implement lifecycle sidecar as a feature enhancement of Boomerang Flow over and above Tekton)
@tlawrie tlawrie added the task label May 21, 2021
@tlawrie tlawrie changed the title Handle result parameters for Script and Custom Tasks Handle result parameters for Tasks with unknown or dynamic results May 21, 2021
@tlawrie
Copy link
Member Author

tlawrie commented Jun 9, 2021

After much investigation, it would become highly complex trying to run the original lifecycle watcher system in the implementation of Tekton. In particular as running as a sidecar, it will be terminated as soon as the main step containers are finished, not giving time to read the files from the container and post back. Alternatively, running the lifecycle as a final step means that it wont always run due to follow on sequential steps only running after prior success.

Linked Issues / TEPs:

The solution here is now to implement the following

  1. Update Task: "Json Path to Result Parameter" to handle retrieving from file.
  2. Update the "HTTP Call" task to off output to File instead of result parameter.
  3. Update the "Execute Shell" task to define result parameters
  4. Update the "Run Custom Task" task to define result parameter

For (3) and (4) above we need to determine best implementation for defining name and description for the result parameters.;
A. Create a tab on the modal for defining result parameters.
B. Create a new section at the bottom for Result Parameters with name, description fields and an add button.

@tlawrie
Copy link
Member Author

tlawrie commented Jun 9, 2021

To handle whether to show the parameter block is custom and script type.

This means migrating the shell and python tasks to be a script type in the collection.

@tlawrie tlawrie added the project: flow Tasks for Boomerang Flow label Jun 9, 2021
@morarucostel morarucostel self-assigned this Jun 10, 2021
@marcusdroy
Copy link

Services have been up pushed up to dev to include spots for saving output properties on a task configuration
"outputs" : [
{
"name" : "test here",
"description" : "description here"
}
]

Also new flow task template type "script" has been introduced so "script" and "custom" will be the tasks which we will display output properties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project: flow Tasks for Boomerang Flow task
Projects
None yet
Development

No branches or pull requests

4 participants