Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ungrouping legacy include nodes with nested operators generates corrupted workflow #1148

Closed
glopesdev opened this issue Nov 15, 2022 · 0 comments · Fixed by #1150
Closed
Labels
bug Something isn't working
Milestone

Comments

@glopesdev
Copy link
Member

glopesdev commented Nov 15, 2022

Following #1126 it seems like ungrouping legacy include nodes with nested operators results in a corrupted workflow after the upgrade.

This seems to be caused by the editor not converting the existing workflow to/from inspectable graph before and after the workflow upgrade. The current upgrade routine requires workflows not to be decorated with any inspectors.

There are two options for fixing the issue:

  1. Convert from/to inspectable graph always before upgrading.
  2. Generalize the upgrade routine to work for any decorator. Generalization of routines for decorator type nodes is waiting for the next major release so we might have to go for a temporary workaround similar to the one used for DisableBuilder nodes in Ensure upgrading does not re-enable disabled nodes #1132.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant