Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify currencies to be fetched #26

Open
emanuelconunaemme opened this issue Jul 18, 2022 · 1 comment
Open

Specify currencies to be fetched #26

emanuelconunaemme opened this issue Jul 18, 2022 · 1 comment

Comments

@emanuelconunaemme
Copy link

Instead of just fetching the first 5000, can we just just pass a list of symbols to fetch? Benefits:

  1. Reducing API credits used
  2. Reducing traffic
  3. Allowing prices for currencies after #5000

Simple implementation: $CURRENCIES is set we hit v2/cryptocurrency/quotes/latest instead, passing it as CSV param.

If you are interested I can push a PR.
@bonovoxly
Copy link
Owner

Sure, looking to freshen this up in the coming months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emanuelconunaemme @bonovoxly