False positive "ranges should only be cuddled with assignments used in the iteration"

[utherbit]

This works correctly, and does not interfere with the following code

func init() {
	foo := make([]int, 0, 10)
	for i := 0; i < 10; i++ {
		foo = append(foo, i)
	}
}

but it complains when I do something before the assignment

func init() {
	foo := make([]int, 0, 10)
	for i := 0; i < 10; i++ {
		_ = 1
		foo = append(foo, i)
	}
}

I get:

for statements should only be cuddled with assignments used in the iteration (wsl)
        for i := 0; i < 10; i++ {
        ^

I'm not happy with this, I don't want to separate this assignment from the for loop

[bombsimon]

This looks like a duplicate of #24. The issue is that we only check the first statement in the block in addition to the line above. It's only mentioned for range in the docs but is true for every block.

The linked ticket suggest to allow for anywhere in the block. I'm currently working on a rewrite and just implemented this but I don't know when that will be released.

[bombsimon]

Closing this, let's discuss in #24 if you want to add more context, details or features.