From 753835a7b7f382fb85183d59e2ba49f329a71d80 Mon Sep 17 00:00:00 2001 From: Bogdan Drutu Date: Fri, 3 Jun 2022 04:37:02 -0700 Subject: [PATCH] Fix TestGenerateAndCompileDefault on windows Fixes https://github.com/open-telemetry/opentelemetry-collector/issues/5403 Signed-off-by: Bogdan Drutu --- cmd/builder/internal/builder/main_test.go | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/cmd/builder/internal/builder/main_test.go b/cmd/builder/internal/builder/main_test.go index ffc25abd6fa..4938cbd0830 100644 --- a/cmd/builder/internal/builder/main_test.go +++ b/cmd/builder/internal/builder/main_test.go @@ -15,10 +15,6 @@ package builder import ( - "io/ioutil" - "log" - "os" - "runtime" "testing" "github.com/stretchr/testify/assert" @@ -45,19 +41,11 @@ func TestGenerateInvalidOutputPath(t *testing.T) { } func TestGenerateAndCompileDefault(t *testing.T) { - if runtime.GOOS == "windows" { - t.Skip("skipping the test on Windows, see https://github.com/open-telemetry/opentelemetry-collector/issues/5403") - } - dir, err := ioutil.TempDir("", "default") - if err != nil { - log.Fatal(err) - } - defer os.RemoveAll(dir) cfg := NewDefaultConfig() - cfg.Distribution.OutputPath = dir + cfg.Distribution.OutputPath = t.TempDir() // we override this version, otherwise this would break during releases - cfg.Distribution.OtelColVersion = "0.38.0" + cfg.Distribution.OtelColVersion = "0.52.0" assert.NoError(t, cfg.Validate()) require.NoError(t, GenerateAndCompile(cfg))