Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conda build for different version of python. Also possibly different platforms (Mac/Windows) #12

Closed
bobfang1992 opened this issue Jun 20, 2020 · 11 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@bobfang1992
Copy link
Owner

As pypi coming into shape this can be put on the map.

@bobfang1992 bobfang1992 self-assigned this Jun 20, 2020
@bobfang1992 bobfang1992 added good first issue Good for newcomers help wanted Extra attention is needed labels Jun 20, 2020
@bobfang1992 bobfang1992 removed their assignment Jun 24, 2020
@h-vetinari
Copy link
Contributor

Hey @bobfang1992, I was planning to ping you once the CI turned green, but now that I stumble over this issue, I thought I'd quickly mention: conda-forge/staged-recipes#14903

@bobfang1992
Copy link
Owner Author

Hi thanks for the effort, what do I need to do here? @h-vetinari

@h-vetinari
Copy link
Contributor

You don't need to do anything in particular, but you're welcome to join in debugging the packaging effort (and even become a co-maintainer of the "recipe" with me, if you want). :)

@bobfang1992
Copy link
Owner Author

Closing this as I am removing conda support. All install should be from pypi from now on.

@h-vetinari
Copy link
Contributor

Closing this as I am removing conda support.

You cannot "remove" conda support, it's already there:

conda install -c conda-forge pytomlpp

works, and will continue to keep working.

All install should be from pypi from now on.

Please don't make this official advice, it's harmful.

@bobfang1992
Copy link
Owner Author

bobfang1992 commented Nov 18, 2021

Hi sorry I was not clear on my message, we used to have an official conda pacakge but I removed it just now because it has a really old version. conda-forge may work but I am not the maintainer of that channel (I think conda-forge guys does it? I cannot remember submitting this pacakge to conda-forge myself.

5B84C610-AC7B-4B75-AC42-CA4B489F5424

But anyway I think the recommended way is to use pypi now. I don't have much time to automate the conda release process. So I wanted to remove it.

@h-vetinari
Copy link
Contributor

I'm one of the people maintaining the conda-forge package. The release process is automated, and 1.0.6 has just been released after I reviewed the changes.

I understand that you don't want to maintain your own channel (and you shouldn't, actually, for several reasons)

I cannot remember submitting this pacakge to conda-forge myself.

I did, and I let you know further up in this thread. 🙃
You're still welcome to join in overseeing how the packaging gets done on the "feedstock": https://github.com/conda-forge/pytomlpp-feedstock

@h-vetinari
Copy link
Contributor

I also left a comment on 2459b40 that I can reiterate here: do you want to have a PR that adds instructions for installing from conda-forge? I strongly recommend that, but then, I'm biased 😅

@bobfang1992
Copy link
Owner Author

bobfang1992 commented Nov 18, 2021 via email

@h-vetinari
Copy link
Contributor

h-vetinari commented Nov 18, 2021

yeah sure I think that's reasonable, but I'd like to emphasis that I think I am not maintaining the conda-forge channel, so please add one world or two if you submit a PR to say that we do not control that distribution. Thanks!

You are obviously not maintaining what you don't know about, but you are welcome to join, as I said. In the meantime, I'm maintaining the conda-forge feedstock where the recipe is hosted and the packages get built in CI.

Except in the most unusual circumstances, support in conda-forge for new versions will be very fast, on the order of a day or so after release. So I don't think people need to be concerned about the maintainership of conda-forge, because it's highly automated & fast, and also I'm explicitly trying to sync & collaborate with you. 🙃

@bobfang1992
Copy link
Owner Author

bobfang1992 commented Nov 18, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants