From 739b4864f4c07c271519781f43f8d90a776cb85d Mon Sep 17 00:00:00 2001 From: Christie Wilson Date: Tue, 9 Oct 2018 12:05:23 -0700 Subject: [PATCH] Update conditions in example runs We don't yet have validation implemented for our Runs, but as of #86 we are using the same Conditions as Knative Build: just `Succeeded` (where unknown means running, true means it finished successfully and false means it finished but failed) --- examples/invocations/kritis-pipeline-run.yaml | 16 +++------------- examples/invocations/run-kritis-test.yaml | 12 +----------- 2 files changed, 4 insertions(+), 24 deletions(-) diff --git a/examples/invocations/kritis-pipeline-run.yaml b/examples/invocations/kritis-pipeline-run.yaml index b076ad869e8..5e70f8a11a8 100644 --- a/examples/invocations/kritis-pipeline-run.yaml +++ b/examples/invocations/kritis-pipeline-run.yaml @@ -17,18 +17,8 @@ status: - taskRef: name: push-kritis-12321312984 conditions: - - type: Started - status: "True" - lastTransitionTime: "2018-10-04T12:25:39Z" - reason: manualTrigger - message: "Pipeline has been triggered manually" - - type: Completed - status: "True" - lastTransitionTime: "2018-10-04T13:25:39Z" - reason: done - message: "Pipeline execution has finished" - - type: Successful + - type: Succeeded status: "False" - lastTransitionTime: "2018-10-04T13:25:39Z" + lastTransitionTime: "2018-10-04T12:25:39Z" reason: taskFailure - message: "TaskRun `build-push-kritis-12321312984` had non-zero exit code" + message: "TaskRun `build-push-kritis-12321312984` had non-zero exit code" \ No newline at end of file diff --git a/examples/invocations/run-kritis-test.yaml b/examples/invocations/run-kritis-test.yaml index e26021d5862..75d2d79dd5f 100644 --- a/examples/invocations/run-kritis-test.yaml +++ b/examples/invocations/run-kritis-test.yaml @@ -27,18 +27,8 @@ status: logsURL: 'gcs://somebucket/results/tests/unit-test-kritis-feature-x/make' exitCode: 0 conditions: - - type: Started + - type: Succeeded status: "True" lastTransitionTime: "2018-10-04T12:25:39Z" - reason: pipelineRun - message: "Task has been triggered by a Pipeline run" - - type: Completed - status: "True" - lastTransitionTime: "2018-10-04T13:25:39Z" - reason: done - message: "Pipeline execution has finished" - - type: Successful - status: "True" - lastTransitionTime: "2018-10-04T13:25:39Z" reason: zeroExitCode message: "All steps completed with an exit code of 0"