Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regular expression execution can panic #1242

Closed
Razican opened this issue May 9, 2021 · 0 comments · Fixed by #1283
Closed

Regular expression execution can panic #1242

Razican opened this issue May 9, 2021 · 0 comments · Fixed by #1283
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics execution Issues or PRs related to code execution
Milestone

Comments

@Razican
Copy link
Member

Razican commented May 9, 2021

The Function::add_rest_param() function can panic with the following error message:

thread 'main' panicked at 'Could not get slice', boa/src/builtins/regexp/mod.rs:413:56

This has been observed when running this ECMAScript test.

Interestingly this only happens when executing the full test suite, and not if we ask the backtrace or run the test individually.

@Razican Razican added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics execution Issues or PRs related to code execution labels May 9, 2021
@Razican Razican added this to the v0.12.0 milestone May 9, 2021
@Razican Razican mentioned this issue May 9, 2021
@Razican Razican modified the milestones: v0.12.0, v0.13.0 May 22, 2021
@0x7D2B 0x7D2B modified the milestones: v0.13.0, v0.12.0 May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics execution Issues or PRs related to code execution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants