Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port BO Avis to BO4E-python #222

Open
9 tasks done
hf-kklein opened this issue Jun 10, 2022 · 1 comment · May be fixed by bo4e/BO4E-python#522
Open
9 tasks done

Port BO Avis to BO4E-python #222

hf-kklein opened this issue Jun 10, 2022 · 1 comment · May be fixed by bo4e/BO4E-python#522
Assignees

Comments

@hf-kklein
Copy link
Collaborator

hf-kklein commented Jun 10, 2022

  • Port our own (Hochfrequenz) Business Object Avis to Python.
    • create an avis.py in bo4e-python: https://github.com/bo4e/BO4E-python/tree/main/src/bo4e/bo
    • run tox and create dev environment (see python template repository)
    • port all the properties from the c# avis class (link above) to the new class in bo4e-python
      • create missing coms and enums in BO4E-python
  • Add tests (to the python implementation) as usual
  • Put focus on a well documented data model (docstrings). Ask for help if necessary.
  • If the CI passes let someone from the Hochfrequenz team review it
  • Do not merge it to bo4e/BO4E-Python yet! We want to use th BO Avis to establish a git based workflow to enhance the official BO4E standard (meaning: someone from another company with functional knowledge should review it)

fyi @hf-krechan

@hf-kklein
Copy link
Collaborator Author

Ah, das hat Daniel schon gemacht 🙈
bo4e/BO4E-python#522

@hf-kklein hf-kklein assigned DeltaDaniel and unassigned OLILHR and hf-crings Jan 11, 2024
@DeltaDaniel DeltaDaniel linked a pull request Apr 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants