Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few changes to the record embeds #619

Closed
pfrazee opened this issue Mar 2, 2023 · 2 comments
Closed

A few changes to the record embeds #619

pfrazee opened this issue Mar 2, 2023 · 2 comments
Assignees

Comments

@pfrazee
Copy link
Collaborator

pfrazee commented Mar 2, 2023

Hey @devinivy now that I'm finally futzing with the record embeds, I'm hitting a couple things I could use changes on. We could group this into the lexicon refactor.

  • We need the indexedAt field somewhere in there I think. Right now we're using createdAt which can be effed with.
  • I was wrong. We do need the presented form to have the presented embeds of the embedded record. Specifically for images. My bad.
  • Right now the presented form ends up with record.record. Not a huge deal but if inspiration hits, it'd be great to have another name for the outer bit.
@pfrazee
Copy link
Collaborator Author

pfrazee commented Mar 3, 2023

We also need to check on:

  • Notifications created for quote posts
  • Quote post count metrics

@dholms
Copy link
Collaborator

dholms commented Apr 4, 2023

fixed #658

@dholms dholms closed this as completed Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants