From 159a6251fdb4ed50f9d296d7bf6791c26f8be224 Mon Sep 17 00:00:00 2001 From: naswierczek Date: Fri, 15 Mar 2024 12:32:34 -0400 Subject: [PATCH] Addressing quality --- records_mover/records/job/mover.py | 4 +--- records_mover/records/mover.py | 16 +++++++++------- records_mover/records/sources/base.py | 2 +- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/records_mover/records/job/mover.py b/records_mover/records/job/mover.py index 6e45a7ca8..0727c6b63 100644 --- a/records_mover/records/job/mover.py +++ b/records_mover/records/job/mover.py @@ -1,6 +1,4 @@ """Create and run jobs to convert between different sources and targets""" -import sys - from records_mover import Session from ..processing_instructions import ProcessingInstructions from ..results import MoveResult @@ -43,7 +41,7 @@ def run_records_mover_job(source_method_name: str, else: run_legacy = True except NotImplementedError as e: - logger.warning(f"""WARNING: This type of move not yet supported in air byte engine. + logger.warning(f"""WARNING: This type of move not yet supported in air byte engine. Falling back to legacy engine. Message: {e}""") run_legacy = True if run_legacy: diff --git a/records_mover/records/mover.py b/records_mover/records/mover.py index d88d971da..c8e17d991 100644 --- a/records_mover/records/mover.py +++ b/records_mover/records/mover.py @@ -70,11 +70,12 @@ def move(records_source: RecordsSource, # See documentation for RecordsSource in sources.py and # RecordsTarget in targets.py for the semantics of the methods # being called. - if (isinstance(records_source, sources_base.SupportsRecordsDirectory) and - isinstance(records_target, SupportsMoveFromRecordsDirectory) and - records_target. - can_move_directly_from_scheme(records_source.records_directory().loc.scheme) and - records_target.can_move_from_format(records_source.records_format)): + if (isinstance(records_source, sources_base.SupportsRecordsDirectory) + and isinstance(records_target, SupportsMoveFromRecordsDirectory) + and records_target.can_move_directly_from_scheme( + records_source.records_directory().loc.scheme + ) + and records_target.can_move_from_format(records_source.records_format)): # Tell the destination to load directly from wherever the # source is, without needing to make any copies of the data or # streaming it through the current box. @@ -140,8 +141,9 @@ def move(records_source: RecordsSource, elif (isinstance(records_source, SupportsMoveToRecordsDirectory) and isinstance(records_target, MightSupportMoveFromTempLocAfterFillingIt) and records_source.has_compatible_format(records_target) and - records_source. - can_move_to_scheme(records_target.temporary_loadable_directory_scheme()) and + records_source.can_move_to_scheme( + records_target.temporary_loadable_directory_scheme() + ) and records_target.can_move_from_temp_loc_after_filling_it()): logger.info(f"Mover: copying from {records_source} to {records_target} " f"by filling in a temporary location...") diff --git a/records_mover/records/sources/base.py b/records_mover/records/sources/base.py index aebd71d6f..ba6e49fb5 100644 --- a/records_mover/records/sources/base.py +++ b/records_mover/records/sources/base.py @@ -152,4 +152,4 @@ class SupportsAirbyte(RecordsSource, metaclass=ABCMeta): @abstractmethod @contextmanager def not_sure_yet(self) -> Iterator['FileobjsSource']: - yield FileobjsSource() \ No newline at end of file + yield FileobjsSource()