Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics published with wrong format #11

Open
rubur-webbeds opened this issue Feb 25, 2019 · 1 comment
Open

Metrics published with wrong format #11

rubur-webbeds opened this issue Feb 25, 2019 · 1 comment

Comments

@rubur-webbeds
Copy link

With the latest release of Prometheus a new metrics' format is required in order to export them successfully.
Upgrading to the prometheus-net.AspNetCore v2.1.3 seems to be enough to publish metrics correctly.

@xordi
Copy link
Contributor

xordi commented Mar 4, 2019

In case you wold like to publish just ASP.NET Core metrics, I would recommend you to upgrade to prometheus-net 3.X and use the Metrics middleware included in this new version. In upcoming versions of Bluekiri.Diagnostics.Prometheus, the collection of metrics related to ASP.NET Core will be removed.

On the other hand, monitoring with the HttpHandlerDiagnosticListener, although still possible, will require some refactorings on the code to make it work properly with prometheus-net 3.0. There is an issue that must be resolved first by the prometheus-net team prometheus-net/prometheus-net#136. Currently we cannnot perform unit tests properly without this issue being fixed first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants