Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Improve doc for 'AudioContextConfig.respectSilence' (#1490) #1500

Merged
merged 4 commits into from
May 14, 2023
Merged

docs: Improve doc for 'AudioContextConfig.respectSilence' (#1490) #1500

merged 4 commits into from
May 14, 2023

Conversation

wujek-srujek
Copy link
Contributor

Description

Improves documentation for AudioContextConfig.respectSilence. It should now be easier to understand what it does.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs:, chore: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality. (n/a)
  • I have updated/added relevant documentation and added dartdoc comments with ///, where necessary.
  • I have updated/added relevant examples in example.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

Fixes #1490.

@Gustl22 Gustl22 merged commit 415dda3 into bluefireteam:main May 14, 2023
@wujek-srujek wujek-srujek deleted the docs/1490-respectSilence-docs branch May 14, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gustl22 Gustl22 Gustl22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation for AudioContextConfig.respectSilence is backwards?
2 participants
@wujek-srujek @Gustl22