Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): make start and resume async #1436

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Conversation

Gustl22
Copy link
Collaborator

@Gustl22 Gustl22 commented Mar 17, 2023

Description

If playing an invalid file (e.g. an empty file), the error is not propagated back to the library, as the error is thrown when starting the play / resume operation.
This ensures that the future of web js play is awaited.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs:, chore: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality. Tests follow in feat!: event channel #1352
  • I have updated/added relevant documentation and added dartdoc comments with ///, where necessary.
  • I have updated/added relevant examples in example.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

@Gustl22 Gustl22 requested a review from spydon March 17, 2023 11:04
@Gustl22 Gustl22 merged commit b95bc8f into main Mar 17, 2023
@Gustl22 Gustl22 deleted the gustl22/web-async-resume branch March 17, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants