Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): Error: "@staticInterop" classes should not contain any generative constructors #1379

Merged
merged 3 commits into from
Jan 12, 2023

Conversation

JonasJW
Copy link
Contributor

@JonasJW JonasJW commented Jan 11, 2023

Description

This PR fixed a build error described here: #1378

It changes all external ... with external factory in packages/audioplayers_web/lib/web_audio_js.dart, as described in this issue flutter/flutter#115988

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs:, chore: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation and added dartdoc comments with ///, where necessary.
  • I have updated/added relevant examples in example.

Note: only minor changes that don't require updating tests, docs or example

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

Fixes #1378

Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, but I have no idea what consequences this has.

@Gustl22 Gustl22 changed the title fix: Error: "@staticInterop" classes should not contain any generative constructors fix(web): Error: "@staticInterop" classes should not contain any generative constructors Jan 11, 2023
@Gustl22 Gustl22 merged commit 21d7050 into bluefireteam:main Jan 12, 2023
@Gustl22
Copy link
Collaborator

Gustl22 commented Jan 12, 2023

Thank you @JonasJW !

@FeodorFitsner
Copy link

Any chance you could publish a new version of audioplayers package sooner? Flutter 3.7 is out and a project compilation is failing. Thank you!

@spydon
Copy link
Member

spydon commented Jan 24, 2023

Any chance you could publish a new version of audioplayers package sooner? Flutter 3.7 is out and a project compilation is failing. Thank you!

Done! audioplayers 3.0.0 is released :)

@FeodorFitsner
Copy link

Wow, that was fast! 🚀 Thank you very much!

Can confirm I'm able to build project with Flutter 3.7 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[audioplayers_web] Error: "@staticInterop" classes should not contain any generative constructors
4 participants