From be460e57593cdad10ec14f1411f40c3a41d17ab8 Mon Sep 17 00:00:00 2001 From: Nidhi Jaju Date: Wed, 21 Oct 2020 07:52:00 +0000 Subject: [PATCH] Revert "Remove NotEnumerable from Transform Streams WebIDL" This reverts commit b52b97cb36de5ae9a366d76548b6f9aa32e234d7. Reason for revert: It is breaking external/wpt/streams/idlharness.any.html based on bisection. Original change's description: > Remove NotEnumerable from Transform Streams WebIDL > > According to https://github.com/whatwg/streams/pull/1035, all methods > and accessors are now enumerable, per Web IDL defaults, instead of > non-enumerable, per ECMAScript defaults. Hence, 'NotEnumerable' can > be removed from the Streams WebIDL files. This CL specifically > removes them from transform streams. > > Bug: 1093862 > Change-Id: I509b470722039ebad20b8caeaa7f34189c24b1ba > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486006 > Commit-Queue: Nidhi Jaju > Reviewed-by: Adam Rice > Cr-Commit-Position: refs/heads/master@{#819230} TBR=ricea@chromium.org,nidhijaju@google.com Change-Id: I7176391031e4bbf89960fe6d7f358a520d06dd21 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1093862 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487745 Reviewed-by: Fergal Daly Commit-Queue: Fergal Daly Cr-Commit-Position: refs/heads/master@{#819275} --- .../blink/renderer/core/streams/transform_stream.idl | 4 ++-- .../core/streams/transform_stream_default_controller.idl | 8 ++++---- .../external/wpt/streams/idlharness.any-expected.txt | 6 +++--- .../wpt/streams/idlharness.any.serviceworker-expected.txt | 6 +++--- .../wpt/streams/idlharness.any.sharedworker-expected.txt | 6 +++--- .../wpt/streams/idlharness.any.worker-expected.txt | 6 +++--- 6 files changed, 18 insertions(+), 18 deletions(-) diff --git a/third_party/blink/renderer/core/streams/transform_stream.idl b/third_party/blink/renderer/core/streams/transform_stream.idl index bb3e38648c2682..ad26ffa35da509 100644 --- a/third_party/blink/renderer/core/streams/transform_stream.idl +++ b/third_party/blink/renderer/core/streams/transform_stream.idl @@ -9,6 +9,6 @@ [CallWith=ScriptState, RaisesException] constructor(optional any transformer, optional any writableStrategy, optional any readableStrategy); - readonly attribute ReadableStream readable; - readonly attribute WritableStream writable; + [NotEnumerable] readonly attribute ReadableStream readable; + [NotEnumerable] readonly attribute WritableStream writable; }; diff --git a/third_party/blink/renderer/core/streams/transform_stream_default_controller.idl b/third_party/blink/renderer/core/streams/transform_stream_default_controller.idl index 68f466afe32cf7..02fc1802f9c07f 100644 --- a/third_party/blink/renderer/core/streams/transform_stream_default_controller.idl +++ b/third_party/blink/renderer/core/streams/transform_stream_default_controller.idl @@ -6,9 +6,9 @@ // https://streams.spec.whatwg.org/#rs-default-controller-class-definition interface TransformStreamDefaultController { - readonly attribute double? desiredSize; - [CallWith=ScriptState, RaisesException] void enqueue( + [NotEnumerable] readonly attribute double? desiredSize; + [CallWith=ScriptState, NotEnumerable, RaisesException] void enqueue( optional any chunk); - [CallWith=ScriptState] void error(optional any reason); - [CallWith=ScriptState] void terminate(); + [CallWith=ScriptState, NotEnumerable] void error(optional any reason); + [CallWith=ScriptState, NotEnumerable] void terminate(); }; diff --git a/third_party/blink/web_tests/external/wpt/streams/idlharness.any-expected.txt b/third_party/blink/web_tests/external/wpt/streams/idlharness.any-expected.txt index e40d7dee99e09d..542c62cc839e5d 100644 --- a/third_party/blink/web_tests/external/wpt/streams/idlharness.any-expected.txt +++ b/third_party/blink/web_tests/external/wpt/streams/idlharness.any-expected.txt @@ -1,5 +1,5 @@ This is a testharness.js-based test. -Found 224 tests; 138 PASS, 86 FAIL, 0 TIMEOUT, 0 NOTRUN. +Found 224 tests; 126 PASS, 98 FAIL, 0 TIMEOUT, 0 NOTRUN. PASS idl_test setup PASS idl_test validation PASS ReadableStreamDefaultReader includes ReadableStreamGenericReader: member names are unique @@ -176,8 +176,8 @@ PASS TransformStream interface object name PASS TransformStream interface: existence and properties of interface prototype object PASS TransformStream interface: existence and properties of interface prototype object's "constructor" property PASS TransformStream interface: existence and properties of interface prototype object's @@unscopables property -PASS TransformStream interface: attribute readable -PASS TransformStream interface: attribute writable +FAIL TransformStream interface: attribute readable assert_true: property should be enumerable expected true got false +FAIL TransformStream interface: attribute writable assert_true: property should be enumerable expected true got false PASS TransformStream must be primary interface of new TransformStream() PASS Stringification of new TransformStream() PASS TransformStream interface: new TransformStream() must inherit property "readable" with the proper type diff --git a/third_party/blink/web_tests/external/wpt/streams/idlharness.any.serviceworker-expected.txt b/third_party/blink/web_tests/external/wpt/streams/idlharness.any.serviceworker-expected.txt index e40d7dee99e09d..542c62cc839e5d 100644 --- a/third_party/blink/web_tests/external/wpt/streams/idlharness.any.serviceworker-expected.txt +++ b/third_party/blink/web_tests/external/wpt/streams/idlharness.any.serviceworker-expected.txt @@ -1,5 +1,5 @@ This is a testharness.js-based test. -Found 224 tests; 138 PASS, 86 FAIL, 0 TIMEOUT, 0 NOTRUN. +Found 224 tests; 126 PASS, 98 FAIL, 0 TIMEOUT, 0 NOTRUN. PASS idl_test setup PASS idl_test validation PASS ReadableStreamDefaultReader includes ReadableStreamGenericReader: member names are unique @@ -176,8 +176,8 @@ PASS TransformStream interface object name PASS TransformStream interface: existence and properties of interface prototype object PASS TransformStream interface: existence and properties of interface prototype object's "constructor" property PASS TransformStream interface: existence and properties of interface prototype object's @@unscopables property -PASS TransformStream interface: attribute readable -PASS TransformStream interface: attribute writable +FAIL TransformStream interface: attribute readable assert_true: property should be enumerable expected true got false +FAIL TransformStream interface: attribute writable assert_true: property should be enumerable expected true got false PASS TransformStream must be primary interface of new TransformStream() PASS Stringification of new TransformStream() PASS TransformStream interface: new TransformStream() must inherit property "readable" with the proper type diff --git a/third_party/blink/web_tests/external/wpt/streams/idlharness.any.sharedworker-expected.txt b/third_party/blink/web_tests/external/wpt/streams/idlharness.any.sharedworker-expected.txt index e40d7dee99e09d..542c62cc839e5d 100644 --- a/third_party/blink/web_tests/external/wpt/streams/idlharness.any.sharedworker-expected.txt +++ b/third_party/blink/web_tests/external/wpt/streams/idlharness.any.sharedworker-expected.txt @@ -1,5 +1,5 @@ This is a testharness.js-based test. -Found 224 tests; 138 PASS, 86 FAIL, 0 TIMEOUT, 0 NOTRUN. +Found 224 tests; 126 PASS, 98 FAIL, 0 TIMEOUT, 0 NOTRUN. PASS idl_test setup PASS idl_test validation PASS ReadableStreamDefaultReader includes ReadableStreamGenericReader: member names are unique @@ -176,8 +176,8 @@ PASS TransformStream interface object name PASS TransformStream interface: existence and properties of interface prototype object PASS TransformStream interface: existence and properties of interface prototype object's "constructor" property PASS TransformStream interface: existence and properties of interface prototype object's @@unscopables property -PASS TransformStream interface: attribute readable -PASS TransformStream interface: attribute writable +FAIL TransformStream interface: attribute readable assert_true: property should be enumerable expected true got false +FAIL TransformStream interface: attribute writable assert_true: property should be enumerable expected true got false PASS TransformStream must be primary interface of new TransformStream() PASS Stringification of new TransformStream() PASS TransformStream interface: new TransformStream() must inherit property "readable" with the proper type diff --git a/third_party/blink/web_tests/external/wpt/streams/idlharness.any.worker-expected.txt b/third_party/blink/web_tests/external/wpt/streams/idlharness.any.worker-expected.txt index e40d7dee99e09d..542c62cc839e5d 100644 --- a/third_party/blink/web_tests/external/wpt/streams/idlharness.any.worker-expected.txt +++ b/third_party/blink/web_tests/external/wpt/streams/idlharness.any.worker-expected.txt @@ -1,5 +1,5 @@ This is a testharness.js-based test. -Found 224 tests; 138 PASS, 86 FAIL, 0 TIMEOUT, 0 NOTRUN. +Found 224 tests; 126 PASS, 98 FAIL, 0 TIMEOUT, 0 NOTRUN. PASS idl_test setup PASS idl_test validation PASS ReadableStreamDefaultReader includes ReadableStreamGenericReader: member names are unique @@ -176,8 +176,8 @@ PASS TransformStream interface object name PASS TransformStream interface: existence and properties of interface prototype object PASS TransformStream interface: existence and properties of interface prototype object's "constructor" property PASS TransformStream interface: existence and properties of interface prototype object's @@unscopables property -PASS TransformStream interface: attribute readable -PASS TransformStream interface: attribute writable +FAIL TransformStream interface: attribute readable assert_true: property should be enumerable expected true got false +FAIL TransformStream interface: attribute writable assert_true: property should be enumerable expected true got false PASS TransformStream must be primary interface of new TransformStream() PASS Stringification of new TransformStream() PASS TransformStream interface: new TransformStream() must inherit property "readable" with the proper type