Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrypt.js sync/async #11

Closed
arsoba opened this issue Oct 29, 2022 · 0 comments · Fixed by #12
Closed

Scrypt.js sync/async #11

arsoba opened this issue Oct 29, 2022 · 0 comments · Fixed by #12

Comments

@arsoba
Copy link
Contributor

arsoba commented Oct 29, 2022

Hello,

Do you really need async scrypt there? You don't use progressCallback.
https://github.com/bloxapp/ssv-keys/blob/main/src/lib/EthereumKeyStore/EthereumKeyStore.ts#L132

Unfortunately, async scryptworks much slower in browser. You can check it using your react example.
Is it possible to use syncScrypt instead?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[EthereumKeyStore] Use syncScrypt instead of scrypt arsoba/ssv-keys
1 participant
@arsoba