Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the "connectUnchecked" method instead of custom UncheckedJsonRpcSigner class #82

Closed
PaulRBerg opened this issue Jul 25, 2021 · 2 comments

Comments

@PaulRBerg
Copy link

PaulRBerg commented Jul 25, 2021

Here's what happened:

  1. I started looking at this demo to understand how to use onboard.js in tandem with ethers.js.
  2. I noticed that I need to create a custom UncheckedJsonRpcSigner class.
  3. I started refactoring it for TypeScript
  4. Two hours later, I was done.
  5. Shortly afterwards, I realised that I wasted my time. Now, ethers.js provides a connectUnchecked method in the JsonRpcSigner class.

See how Uniswap uses it: https://github.com/Uniswap/uniswap-interface/blob/4078390a4890445d1ff0ed5196fd4cb56a44de87/src/utils/index.ts#L28-L30

@lnbc1QWFyb24
Copy link
Collaborator

Ahh man sorry you spent all of that time refactoring that class to TypeScript. It's great that they have that connectUnchecked method now. We will get this updated, thanks mate!

@Adamj1232
Copy link
Member

We have updated to the latest Ethers provider and all seems to be working as expected. Thanks again for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants