Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to blitz core #873

Closed
flybayer opened this issue Feb 27, 2020 · 5 comments · Fixed by blitz-js/blitz#16
Closed

Add tests to blitz core #873

flybayer opened this issue Feb 27, 2020 · 5 comments · Fixed by blitz-js/blitz#16

Comments

@flybayer
Copy link
Member

flybayer commented Feb 27, 2020

Blitz core is currently untested. We need to add comprehensive tests. This would be a good task for anyone who wants it!

Comment below if you're getting ready to work on it

@jasonblalock
Copy link

I'd love to take a crack at this

@MrLeebo
Copy link
Member

MrLeebo commented Feb 27, 2020

I checked it out, tried to use the nextjs tests as a template, but the next-test-utils dependency isn't public so we'd have to replace that or come at it a different way.

@jasonblalock
Copy link

Yeah, @MrLeebo I see what you mean. I was able to copy the test-utils and get that compiling properly (not that I think that's the ideal solution). But there's a ton of config/packages that goes into their integration tests that I'm not sure the right move is to copy it. Not to mention they use selenium for all their stuff and I don't know if that's the direction we want to be entrenched.

I'm going to back away from this one for now. I'm going out of town in a day and it's going to take a deeper dive than I'll have time for this week to build out a testing harness. I don't want to be in the way.

@emeraldsanto
Copy link
Contributor

If by any chance this hasn't been taken care of when I get back home on Sunday, I will gladly start working on it!

@MrLeebo
Copy link
Member

MrLeebo commented Feb 27, 2020

I started a PR (#16), but I'm sure there's more testing to be done.

@dillondotzip dillondotzip transferred this issue from blitz-js/blitz Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants