Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database fields too short #23

Open
pjz opened this issue Apr 28, 2015 · 1 comment
Open

Database fields too short #23

pjz opened this issue Apr 28, 2015 · 1 comment

Comments

@pjz
Copy link
Contributor

pjz commented Apr 28, 2015

Currently Broker has:

phone_number_1        = Column(String(15))
phone_number_2        = Column(String(15))
skype                 = Column(String(30))
email                 = Column(String(15))

which strike me as a bit... short. Your demo data (in bootstrap/demo.ini) thinks so too, since it overflows the email field (len("user@blinktrade.com") is > 15).

My suggested fix is to make phone numbers 30 characters and skype and email 254 characters. I could submit a PR, but I don't know how you guys are doing schema change management so didn't want to trample on it and risk messing with someone's live database.

Also, the name field in DepositMethods should likely be increased to 30; the current 15 is overflowed by demo.ini's usps_money_order.

@pjz pjz changed the title Broker fields too short Database fields too short Apr 28, 2015
@pinhopro
Copy link
Member

Good point. Since I am using sqlite3, I didn't catch those. I will be replacing those.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants