Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current bleve release broken by more recent change? #1879

Closed
bmhatfield opened this issue Sep 7, 2023 · 4 comments
Closed

Current bleve release broken by more recent change? #1879

bmhatfield opened this issue Sep 7, 2023 · 4 comments

Comments

@bmhatfield
Copy link

go/pkg/mod/github.com/blevesearch/bleve/v2@v2.3.9/search/searcher/search_geoshape.go:107:32: not enough arguments in call to geojson.FilterGeoShapesOnRelation
	have (index.GeoJSON, []byte, string, **bytes.Reader)
	want (index.GeoJSON, []byte, string, **bytes.Reader, *s2.GeoBufferPool)

Seems to have been changed in #1864 but go get -u github.com/blevesearch/bleve/v2 brings it in, it seems?

@bmhatfield
Copy link
Author

Forcibly rolling that back in go.mod results in more breaking changes:

go/pkg/mod/github.com/blevesearch/bleve/v2@v2.3.9/index_impl.go:651:26: assignment mismatch: 2 variables but docF.DateTime returns 3 values

which appears to be the result of an update to github.com/blevesearch/bleve_index_api v1.0.6

@bmhatfield
Copy link
Author

Jason in the Gophers Slack helped point me in the right direction; -u caused a dependency update overfetch.

Screenshot 2023-09-06 at 9 50 49 PM

That said, it's probably worth cutting a Bleve release given the breaking changes in supporting libraries.

@bmhatfield
Copy link
Author

Going to leave open as a request to cut a new release; feel free to close as desired.

@abhinavdangeti
Copy link
Member

@bmhatfield we'll be making a release later in this month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants