Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GaoIt class has wrong name for its dict in some functions. #8

Closed
blakeaw opened this issue Jun 6, 2022 · 1 comment
Closed

GaoIt class has wrong name for its dict in some functions. #8

blakeaw opened this issue Jun 6, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@blakeaw
Copy link
Owner

blakeaw commented Jun 6, 2022

The GaoIt class uses the wrong name, parm, for its parameter dictionary in some functions where it should be be parms which causes an error. So far, noticed in the following functions:

  • __delitem__
  • sampled_parameters

There may be other functions affected, so they should be double-checked.
@blakeaw blakeaw added the bug Something isn't working label Jun 6, 2022
@blakeaw
Copy link
Owner Author

blakeaw commented Jul 24, 2024

Fix included in PR #11

@blakeaw blakeaw closed this as completed Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@blakeaw