Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codecov fails spuriously #343

Closed
rlouf opened this issue Sep 23, 2022 · 1 comment
Closed

Codecov fails spuriously #343

rlouf opened this issue Sep 23, 2022 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@rlouf
Copy link
Member

rlouf commented Sep 23, 2022

It recently failed on #327 which was just about correcting a link on the README. This should not happen.
@rlouf rlouf added the help wanted Extra attention is needed label Sep 23, 2022
@rlouf
Copy link
Member Author

rlouf commented Sep 24, 2022

You can set a threshold when in codecov.yml, but the Github Action does not support this parameter yet: codecov/codecov-action#554.

To make things slightly better temporarily I suggest we disable Codecov when pushing on main, only keep in on PRs. I don't want to have that red cross on the repo's main page when there's no reason for it.

@rlouf rlouf closed this as not planned Won't fix, can't repro, duplicate, stale Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rlouf