Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #157 - Replace eslint with standard js #168

Merged
merged 1 commit into from
Jun 6, 2022

Conversation

jaredmoody
Copy link
Contributor

No description provided.

@jaredmoody jaredmoody force-pushed the standard-js branch 2 times, most recently from 2743d0c to 8f8b257 Compare April 19, 2022 06:10
@jaredmoody jaredmoody marked this pull request as draft April 19, 2022 06:14
@jaredmoody
Copy link
Contributor Author

jaredmoody commented Jun 5, 2022

@aidewoode this is complete except for this one failing test, which I'm not sure why is failing. It looks like the test is expecting the loaded page to only have the albums that were created for the test itself, but there are four more that are on the page that are coming from fixtures.

I could just change the test to assert the number that are on the page, but I'm not sure why this test was passing before and now is not. Can you take a look?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2438334580

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.839%

Totals Coverage Status
Change from base Build 2427163858: 0.0%
Covered Lines: 766
Relevant Lines: 791

💛 - Coveralls

@aidewoode
Copy link
Member

There are some test cases in system test will randomly failed. I am not quite sure the reason, I will take time to invistegate this. For now, if you face the issue, just rerun the action job, those test cases will be passed.

@aidewoode aidewoode marked this pull request as ready for review June 6, 2022 03:08
@aidewoode aidewoode merged commit c513ac0 into blackcandy-org:master Jun 6, 2022
@jaredmoody jaredmoody deleted the standard-js branch June 6, 2022 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants